Deprecate ModelProxy#valid_child_concerns

This method isn't releted to the `ModelProxy` concern. It is deprecated, with the relevant implementation moved to `WorkShowPresenter`.
samvera · Jan 10, 2020 · c34dc0d · c34dc0d
1 parent e4b4439
commit c34dc0d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/app/presenters/hyrax/model_proxy.rb b/app/presenters/hyrax/model_proxy.rb
@@ -18,7 +18,11 @@ def to_model
       self
     end
 
+    ##
+    # @deprecated this isn't related to the ModelProxy issue, and has been moved
+    #   to `WorkShowPresenter`.
     def valid_child_concerns
+      Deprecation.warn "#{self.class}#valid_child_concerns will be removed in Hyrax 4.0."
       Hyrax::ChildTypes.for(parent: solr_document.hydra_model)
     end
 

diff --git a/app/presenters/hyrax/work_show_presenter.rb b/app/presenters/hyrax/work_show_presenter.rb
@@ -231,6 +231,12 @@ def show_deposit_for?(collections:)
       collections.present? || current_ability.can?(:create_any, ::Collection)
     end
 
+    ##
+    # @return [Array<Class>]
+    def valid_child_concerns
+      Hyrax::ChildTypes.for(parent: solr_document.hydra_model).to_a
+    end
+
     private
 
       # list of item ids to display is based on ordered_ids