Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
Hyrax::Actors::TransactionalRequest
from default middleware
The actor stack involves writing to several diffrent persistence layers; at least: - ActiveRecord - ActiveFedora (Fedora/Solr) - ActiveJob The transactionality provided by `Hyrax::Actors::TransactionalRequest` addresses only one of these (ActiveRecord). Routinely, failures in the actor stack that trigger transaction rollback there lead to broken states across the various data stores. Additionally, this rollback is not triggered for the main documented failure API for the stack (returning `false`). Rollback only happens when uncaught errors are propagated to the top of the stack. Since this middleware is problematic and doesn't have a clear documented use case, this proposes its removal. Fixes #3128.
- Loading branch information