Changes behavior for Collection tabs.

app/assets/javascripts/hyrax.js

@@ -40,7 +40,6 @@
 //= require hyrax/nav_safety
 //= require hyrax/analytics_events
 //= require hyrax/select_submit
-//= require hyrax/tabs
 //= require hyrax/user_search
 //= require hyrax/proxy_rights
 //= require hyrax/sorting

app/views/hyrax/my/collections/_tabs.html.erb

@@ -1,8 +1,15 @@
+<% current_page_dashboard = current_page?(hyrax.dashboard_collections_path(locale: nil)) %>
 <ul class="nav nav-tabs" id="my_nav" role="navigation">
-  <li<%= ' class="nav-item"'.html_safe if current_page?(hyrax.dashboard_collections_path(locale: nil)) %>>
-    <%= link_to t("hyrax.dashboard.#{current_ability.admin? ? 'all' : 'managed'}.collections"), hyrax.dashboard_collections_path, class: "nav-link" %>
+  <li<%= ' class="nav-item"'.html_safe if current_page_dashboard %>>
+    <%= link_to(
+      t("hyrax.dashboard.#{current_ability.admin? ? 'all' : 'managed'}.collections"), 
+      hyrax.dashboard_collections_path, 
+      class: "nav-link#{' active' if current_page_dashboard}") %>
   </li>
-  <li<%= ' class="nav-item"'.html_safe if current_page?(hyrax.my_collections_path(locale: nil)) %>>
-    <%= link_to t('hyrax.dashboard.my.your_collections'), hyrax.my_collections_path, class: "nav-link active" %>
+  <li<%= ' class="nav-item"'.html_safe if !current_page_dashboard %>>
+    <%= link_to(
+      t('hyrax.dashboard.my.your_collections'), 
+      hyrax.my_collections_path, 
+      class: "nav-link#{' active' if !current_page_dashboard}") %>
   </li>
 </ul>

spec/features/collection_type_spec.rb

@@ -378,7 +378,7 @@
         end
 
         # forwards to Dashboard -> Collections -> All Collections
-        within('li.active') do
+        within('.nav-tabs li.nav-item') do
           expect(page).to have_link('All Collections')
         end