Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display bugs on Work form > Sharing tab #3972

Closed
dlim87 opened this issue Sep 12, 2019 · 2 comments
Closed

Display bugs on Work form > Sharing tab #3972

dlim87 opened this issue Sep 12, 2019 · 2 comments
Assignees
@fritzfreiheit
Labels
bug
Milestone
3.x series

Comments

@dlim87
Copy link

dlim87 commented Sep 12, 2019 •
edited
Loading

Descriptive summary

There are 3 display bugs on the New/edit work page, sharing tab:

  • In the alert box, raw HTML and ASCII codes are not being translated
  • In the "add groups" section, the button has raw HTML
  • On the access list, the current user has a (translation?) display bug

Image 2019-09-12 at 9 21 43 AM

Rationale

HTML should be properly rendered

Expected behavior

Html should be properly rendered

Actual behavior

HTML tags are showing up

Steps to reproduce the behavior

  1. Log in
  2. Click on share your work
  3. Make sure it's in an admin set that allows sharing (the default admin set should work)
  4. Click on the sharing tab

Related work

Another HTML error: #3959
The original work (and thus files) for this view: #2237

Tested on Mac and windows - Chrome 76.0.3809.132,
Mac - Safari 12.1.2,
Windows - Firefox 69.0

hyrax info Hyrax Version: 3.0.0.pre.rc1 Hyrax Branch: master Hyrax Revision: 48ed925

Nurax Version
ENV: production
SHA: 40b47b0d71af1b958e016ebe49212c1740683133
Branch: 2019-09-12-10-00
Updated: 12 Sep 2019 15:00:37
@no-reply no-reply added this to the 3.x series milestone Sep 12, 2019
@no-reply no-reply added the bug label Sep 12, 2019
@blancoj
Copy link
Contributor

blancoj commented Sep 12, 2019

This will be taken care of by this PR #3945

@mcdowney mcdowney mentioned this issue Sep 12, 2019
Closed
@fritzfreiheit fritzfreiheit self-assigned this Oct 28, 2019
fritzfreiheit added a commit that referenced this issue Oct 30, 2019
@fritzfreiheit
Fix for HYRAX-#3972
edf287d 
The edit works share tab displays raw html at several locations.

Expected behavior:
The edit works share tab does not display raw html.

In order to test:
* Log in as Administrator
* Edit a work
* Click on "Sharing" tab
* Under header "Currently Shared With":
** should display "Depositor(<some email>)"
* Under header "Add Sharing" add a group permission:
** by selecting from "Group" and "Choose Access" pull downs, then "Add"
** The message 'Permissions are not saved until the "Save" button is
   pressed at the bottom of the page.' appears and does not contain raw html.
fritzfreiheit added a commit that referenced this issue Oct 30, 2019
@fritzfreiheit
Fix for HYRAX-#3972
e076a28 
The edit works share tab displays raw html at several locations.

Expected behavior:
The edit works share tab does not display raw html.

In order to test:
* Log in as Administrator
* Edit a work
* Click on "Sharing" tab
* Under header "Currently Shared With":
** should display "Depositor(<some email>)"
* Under header "Add Sharing" add a group permission:
** by selecting from "Group" and "Choose Access" pull downs, then "Add"
** The message 'Permissions are not saved until the "Save" button is
   pressed at the bottom of the page.' appears and does not contain raw html.
@fritzfreiheit fritzfreiheit mentioned this issue Oct 30, 2019
Merged
no-reply pushed a commit that referenced this issue Oct 31, 2019
@fritzfreiheit
Fix for HYRAX-#3972 (#4138)
1a359d1 
* Fix for HYRAX-#3972

The edit works share tab displays raw html at several locations.

Expected behavior:
The edit works share tab does not display raw html.

In order to test:
* Log in as Administrator
* Edit a work
* Click on "Sharing" tab
* Under header "Currently Shared With":
** should display "Depositor(<some email>)"
* Under header "Add Sharing" add a group permission:
** by selecting from "Group" and "Choose Access" pull downs, then "Add"
** The message 'Permissions are not saved until the "Save" button is
   pressed at the bottom of the page.' appears and does not contain raw html.

Co-Authored-By: Tom Johnson <tomjohnson@ucsb.edu>
@dlim87
Copy link
Author

dlim87 commented Nov 6, 2019

This is rendering properly
Image 2019-11-06 at 9 57 12 AM

@jeremyf jeremyf closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fritzfreiheit fritzfreiheit

Labels
bug
Projects
None yet
Milestone
3.x series
Development

No branches or pull requests
5 participants
@jeremyf @no-reply @dlim87 @blancoj @fritzfreiheit