Adding work to multiple single membership collections from edit work form does not forward as expected

[elrayle]

Descriptive summary

This issue lays out expected forwarding behavior when adding a work to multiple collections through the edit work form fails.

NOTE: This likely uses the same behaviors when performing the same actions on the new work form. This issue and issue #4010 are tightly related and the fix for one may fix both.

Rationale

Provide intuitive forwarding behavior that focuses on the actions a user will most likely want to take next. Provide error message that is easy to understand.

Expected behavior

When adding a work to multiple collections from the work edit form...

FAILURE to add the work to the collections should:

• stay on edit form (Relationships tab)
• no changes are saved
• should maintain changes to metadata fields (Descriptions tab)
• should maintain any files added for upload (Files tab)
• show flash error (red): Collections Error: You have specified more than one collection of the same single-membership collection type (collection type: name of collection type, collections: list of effected collections). The work was not added to those collections.

Testing

• Need to update specs added in PR fix single membership and add single/multi-membership spec tests #2687 to match the forwards described in this issue.

Actual behavior

When adding a work to multiple collections from the work edit form...

FAILURE to add the work to the collections should:

• forwards to Descriptions tab on edit form
• no changes are saved
• all metadata fields are reset (Descriptions tab)
• files for upload are no longer listed (Files tab)
• shows flash error: Collections Error: You have specified more than one of the same single-membership collection type (type: name of collection type, collections: list of effected collections)

Steps to reproduce the behavior

Prerequisites:

Need a collection type that is set to allow single membership. If testing on Nurax, this collection type may already exist. Look for Collection Type Single Membership. If it doesn't exist, then create a single membership collection type using...

• Dashboard -> Settings -> Collection Types -> Create new collection type
• Assign type name Single Membership and Save
• On Settings tab, uncheck MULTIPLE MEMBERSHIP and Save changes

Need two collections of type Single Membership. You can create using...

• Dashboard -> Collections -> New Collection -> select Single Membership type -> Create Collection
• Assign suitable titles for the two collections and save. This issue will refer to them as SM1 and SM2.

Need the work to already exist. Create a work using...

• Dashboard -> Works -> Add new work -> select type -> fill in requirements -> Save. This issue will refer to them as Work1.

Test:

Verify FAILURE behaves as expected.

1. Dashboard -> Works -> click title for Work 1 -> Edit
2. change some metadata on Descriptions tab
3. add file on Files tab
4. check box for Depositor Agreement (if required)
5. on Relationships tab -> Collections -> Add to collection -> type SM1 -> Add
6. on Relationships tab -> Collections -> Add to collection -> type SM2 -> Add
7. click Save changes button

• Verify stays in edit form on Relationships tab.
• Verify flash error (red) with message "Collections Error: You have specified more than one collection of the same single-membership collection type (collection type: Single Membership, collections: SM1, SM2). The work was not added to those collections."
• Verify that metadata changed on Descriptions tab still has the updated value.
• Verify that any files added on the Files tab are still ready for upload.
• Verify changes were not saved.

Related work

• Issue Batch add works to collection from Dashboard->Works when all fail doesn't forward as expected #4006 Batch add works to collection from Dashboard->Works when all fail doesn't forward as expected
• Issue Batch add works to collection from Dashboard->Works when some fail doesn't forward as expected #4007 Batch add works to collection from Dashboard->Works when some fail doesn't forward as expected
• Issue Batch add works to collection from collection admin show page when all fail doesn't forward as expected #4008 Batch add works to collection from collection admin show page when all fail doesn't forward as expected
• Issue Batch add works to collection from collection admin show page when some fail doesn't forward as expected #4009 Batch add works to collection from collection admin show page when some fail doesn't forward as expected
• Issue Adding work to multiple single membership collections from new work form does not forward as expected #4010 Adding work to multiple single membership collections from new work form does not forward as expected
• PR fix single membership and add single/multi-membership spec tests #2687 - fix single membership and add single/multi-membership spec tests