5594-single-membership-error-messages #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this commit, the flash message would show an error above the form AND there would be another error messa ge that showed within the form. these messages would be for the same reason. instead, this commit shows unique error m essages above the form only. ref: #5594 co-authored-by: rob <rob@scientist.com>
now that we are passing the GenericWorkForm instead of the SimpleForm::FormBuilder to the error partials in flash_msg.html.erb, #object is no longer an available method
… in the translation file
alishaevn
commented
Jun 6, 2023
jeremyf
reviewed
Jun 6, 2023
…_message_types`. this reduces the duplication of knowledge between the work form helper and flash message. it will also allow for better future debugging. co-authored-by: jeremy <jeremy.n.friesen@gmail.com>
alishaevn
force-pushed
the
5594-single-membership-error-messages
branch
from
74bd469
to
72a92dd
Compare
alishaevn
commented
Jun 7, 2023
…k for the new selector.
…rb_spec.rb:138" we are now rendering form edit errors from the flash message, not the form partial.
the valkyrie form initialization is nested way down in the disposable gem. https://github.com/apotonick/disposable/blob/v0.6.3/lib/disposable/twin/changed.rb\#L25
alishaevn
force-pushed
the
5594-single-membership-error-messages
branch
from
300a5e4
to
9e78b4f
Compare
…matted. also update the flash_msg spec
alishaevn
commented
Jun 9, 2023
| @@ -97,112 +97,5 @@ def form_file_set_select_for(parent:) | |||
| hash[presenter.title_or_label] = presenter.id | |||
| end | |||
| end | |||
|
|
|||
| ## | |||
| # This helper retrieves errors based on form type. | |||
There was a problem hiding this comment.
since we're no longer rendering error messages from "app/views/hyrax/base/_form.html.erb", these methods are no longer called.
…rently. although Hyrax::GenericWorkForm could not be found in koppie when I ran the specs locally with ruby v3.2.1, it was found in the ci pipeline with ruby v2.7.x. I do not know the reason for the difference, but instead of handling the koppie app one way, and hyrax another....we will just search for one version of the class and fall back to the other.
|
"spec/services/hyrax/collections/collection_member_service_spec.rb:203" is failing in the I ran the pipeline in ci again, and again it has failed. 😞 |
labradford
approved these changes
Jun 9, 2023
aprilrieger
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
errorsfor <GenericWork> when adding work to two collections of same single membership type (nurax-pg) #5594Summary
move and consolidate the "work form edit" related errors to the flash message.
Demo
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
Detailed Description
before this change, the flash message would show an error above the form AND there would be another error message that showed within the form. these messages would be for the same reason. instead, this commit shows unique error messages above the form only.
@samvera/hyrax-code-reviewers