Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics Graph is not responsive on mobile devices #4530

Closed
njaffer opened this issue Oct 1, 2020 · 3 comments
Closed

Analytics Graph is not responsive on mobile devices #4530

njaffer opened this issue Oct 1, 2020 · 3 comments

Comments

@njaffer
Copy link
Contributor

njaffer commented Oct 1, 2020

Descriptive summary

Analytics Graph is not responsive on mobile devices. Additionally, it is not accessible by screen readers.

Rationale

When testing Hyrax, nurax on a mobile device, the analytics page has two graphs that do not scale according to the screen size.

Expected behavior

The graphs should be responsive to the screen size

Actual behavior

The graphs extends the screen size on a mobile device

Steps to reproduce the behavior

  1. View a work
  2. Click on Analytics button

Related work

@no-reply
Copy link
Contributor

no-reply commented Oct 5, 2020

Additionally, it is not accessible by screen readers.

can we break this out into a separate ticket and tag accessibility-concern? i think this should be described and prioritized separately from the responsiveness issue.

no-reply pushed a commit that referenced this issue Oct 7, 2020
this addresses (part of) #4530.

analytics graphs were lacking device responsivity because width was hard
coded. shifting to `max-width` allows the graphs to generate for the appropriate
screen size.
jeremyf pushed a commit that referenced this issue Oct 7, 2020
this addresses (part of) #4530.

analytics graphs were lacking device responsivity because width was hard
coded. shifting to `max-width` allows the graphs to generate for the appropriate
screen size.
@njaffer
Copy link
Contributor Author

njaffer commented Oct 7, 2020

yeah sure, I will create another ticket and tag accessibility-concern

@orangewolf orangewolf mentioned this issue Sep 1, 2021
orangewolf added a commit that referenced this issue Dec 3, 2021
Fixes #4564 #4530 #3551 #2542 #2566 Maybe others?

This work was sponsored by Oregon Digital as part of the IMLS National Leadership Grant to support its project, Open Impact: Developing Robust Analytics for Open Source Solution Bundle Hyrax.

This code overhauls the built in display of reports and metrics for Hyrax. It makes it compatible with both GA v3 and Matomo and lays ground work for other adapters in the future.

Changes proposed in this pull request:

Turn analytics on/off, choose your analytics provider of choice (google or matomo), and set api details in an ENV file
Wire up graphs on dashboard to work based off analytics data (number of total visitors, returning visitors, new user signups)
New tab in dashboard sidebar for "analytics reports". Dropdown includes options for "Work Reports" or "Collection Reports"
Design and develop Work and Collection reports to show views and download counts for individual files. Data is set by default to last 30 days, by month by month, as well as custom date range. This data is pulled in directly from Google or Matomo API's.
View and Download counts are available to be exported to .csv format

Co-authored-by: Alisha Evans <alisha@notch8.com>
Co-authored-by: Sara G <its.sara.geezy@gmail.com>
Co-authored-by: Sara G <geezy@Notch8-MacBook-Pro.local>
Co-authored-by: April Rieger <april@notch8.com>
Co-authored-by: April Rieger <63515648+aprilrieger@users.noreply.github.com>
Co-authored-by: Sara G <platinummix@yahoo.com>
Co-authored-by: tamsin johnson <tomjohnson@ucsb.edu>
@jlhardes
Copy link
Contributor

Analytics updates tested via Nurax-dev are displaying graphs that resize on a mobile device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants