Lease date field error when non-date text entered #4757
Comments
|
In both firefox and chrome on windows, I'm unable to enter non-numeric characters into the Lease date field. @crisr15 can you duplicate this on a Mac? |
|
Safari on Mac is not giving a date picker for Lease or Embargo date fields for me so maybe that is the problem here. I am able to completely remove the default value and enter any text but then that seems to produce the error screen. Chrome on Mac and Firefox on Mac are both showing the date picker. In those browsers, the only way I can enter a value is as a structured date. |
|
@jlhardes can we call this one a non-blocker for 3.0.0 then? i'm tempted to say it's still high-priority, but since it's browser specific i'm inclined to put it in as a 3.0.1. thoughts? |
|
Yes, I think this is not a blocker for 3.0 but it is a priority for 3.x. |
|
I will be debugging and testing with Safari. |
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
Prior to this commit, we were not verifying that a user's input for a release_date was in fact a parseable date. Chrome and Firefox apply a date picker "widget" that enforces entries for a `type="date"`. However, Safari does not. Closes #4757 Note, to test this in the UI requires a fix for #4833. That fix, at the time of crafting this commit message, can be seen at PR #4885.
|
It is no longer possible to enter non-date text on Safari for Lease or Embargo dates. This is fixed! |
Descriptive summary
In Hyrax 3.x, entering non-date text in the Lease date field ("asdfas", for example) on a Work produces a stack trace error when saving the Work.
Rationale
Stack trace errors shouldn't happen for this action.
Expected behavior
Error message should show on Work form (like it does when doing this same action on Embargo) to indicate:
Visibility When setting visibility to "lease" you must also specify lease reduced access date.
Lease reduced access date Must be a future date.
Error checking applied to Embargo seems to not be applied to Lease.
Actual behavior
See attached stack trace error screenshot
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: