Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App generated through template includes file_set model that is an AF::Base model #5098

Closed
elrayle opened this issue Sep 10, 2021 · 0 comments · Fixed by #6392
Closed

App generated through template includes file_set model that is an AF::Base model #5098

elrayle opened this issue Sep 10, 2021 · 0 comments · Fixed by #6392
Assignees
@rawOrlando
Labels
Effort: Minor question valkyrization

Comments

@elrayle
Copy link
Contributor

elrayle commented Sep 10, 2021 •
edited
Loading

Descriptive summary

The generated app/model/file_set.rb extends ActiveFedora::Base. To move to Valkyrie, the generated file set model needs to be_a Hyrax::Resource.

It is unclear if the generated file set is needed. Is there a reason not to just use Hyrax::FileSet?

Rationale

All models should be_a Hyrax::Resource to work with Valkyrie persistence.

Expected behavior

Generating a new Hyrax app using template.rb creates FileSet < Hyrax::FileSet in the new app's app/models/file_set.rb.

QUESTION:

It is unclear if the generated file set is needed. Is there a reason not to just use Hyrax::FileSet?

Actual behavior

Generating a new Hyrax app using template.rb creates FileSet < ActiveFedora::Base in the new app's app/models/file_set.rb.

Steps to reproduce the behavior

  1. Generate a new Hyrax app using...
rails _5.2.6_ new my_hyrax -m https://raw.githubusercontent.com/samvera/hyrax/v3.1.0/template.rb

NOTE: May need to adjust the tag from v3.1.0 to the latest version tag for Hyrax.

Related Work

Issue #5099 App generated through template includes collection model that is an AF::Base model
Issue #5100 App generated by template includes .fcrepo_wrapper for connecting to Fedora
@elrayle elrayle added the wings label Sep 10, 2021
@elrayle elrayle mentioned this issue Sep 10, 2021
Open
@elrayle elrayle mentioned this issue Sep 10, 2021
Open
@rawOrlando rawOrlando self-assigned this Oct 26, 2023
rawOrlando added a commit that referenced this issue Oct 26, 2023
@rawOrlando
#5098 Valkyrize FileSet Generator
2bd7f11
@rawOrlando rawOrlando mentioned this issue Oct 26, 2023
Merged
jeremyf pushed a commit that referenced this issue Jan 19, 2024
@rawOrlando @jeremyf
#5098 Valkyrize FileSet Generator
7a4f709
jeremyf added a commit that referenced this issue Jan 19, 2024
@jeremyf
Merge branch 'main' into double_combo-with-main-sauce
e745880 
* main: (264 commits)
  #5098 Valkyrize FileSet Generator
  Converts collection in spec/features/collection_type_spec.rb and highlights bug.
  Valkyrizes spec/views/hyrax/batch_edits/edit.html.erb_spec.rb.
  Accounts for Valkyrie's schema parsing dates differently in spec/hyrax/schema_spec.rb.
  Edit work_form_helper_spec.rb
  Marks spec/forms/hyrax/forms/batch_edit_form_spec.rb as ActiveFedora-only.
  Adds switch for expected solr cor in spec/valkyrie/indexing/solr/indexing_adapter_spec.rb.
  Corrects spec/search_builders/hyrax/my/collections_search_builder_spec.rb after environment behaviors correction.
  Marks spec/presenters/hyrax/member_presenter_factory_spec.rb as ActiveFedora-only.
  Edit iiif_manifest_cache_prewarm_job_spec.rb
  Edit create_work_admin_spec.rb
  Valkyrizes spec/services/hyrax/embargo_service_spec.rb.
  Accounts for Koppie's config in `spec/models/flipflop_spec.rb`. (#6603)
  Valkyrizes spec/features/iiif_manifest_spec.rb.
  Edit sipity_spec.rb
  Edit move_all_works_to_admin_set_spec.rb
  Edit work_query_service_spec.rb
  Marks spec/models/concerns/hyrax/solr_document/ordered_members_spec.rb as ActiveFedora-only.
  Makes `spec/services/hyrax/valkyrie_upload_spec.rb` friendly for both Koppie and Dassie. (#6591)
  Valkyrizes spec/features/dashboard/my_works_spec.rb.
  ...
jeremyf added a commit that referenced this issue Jan 19, 2024
@jeremyf
Merge branch 'main' into double_combo
4d48b06 
* main: (264 commits)
  #5098 Valkyrize FileSet Generator
  Converts collection in spec/features/collection_type_spec.rb and highlights bug.
  Valkyrizes spec/views/hyrax/batch_edits/edit.html.erb_spec.rb.
  Accounts for Valkyrie's schema parsing dates differently in spec/hyrax/schema_spec.rb.
  Edit work_form_helper_spec.rb
  Marks spec/forms/hyrax/forms/batch_edit_form_spec.rb as ActiveFedora-only.
  Adds switch for expected solr cor in spec/valkyrie/indexing/solr/indexing_adapter_spec.rb.
  Corrects spec/search_builders/hyrax/my/collections_search_builder_spec.rb after environment behaviors correction.
  Marks spec/presenters/hyrax/member_presenter_factory_spec.rb as ActiveFedora-only.
  Edit iiif_manifest_cache_prewarm_job_spec.rb
  Edit create_work_admin_spec.rb
  Valkyrizes spec/services/hyrax/embargo_service_spec.rb.
  Accounts for Koppie's config in `spec/models/flipflop_spec.rb`. (#6603)
  Valkyrizes spec/features/iiif_manifest_spec.rb.
  Edit sipity_spec.rb
  Edit move_all_works_to_admin_set_spec.rb
  Edit work_query_service_spec.rb
  Marks spec/models/concerns/hyrax/solr_document/ordered_members_spec.rb as ActiveFedora-only.
  Makes `spec/services/hyrax/valkyrie_upload_spec.rb` friendly for both Koppie and Dassie. (#6591)
  Valkyrizes spec/features/dashboard/my_works_spec.rb.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawOrlando rawOrlando

Labels
Effort: Minor question valkyrization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5098 Valkyrize FileSet Generator samvera/hyrax
3 participants
@jlhardes @elrayle @rawOrlando