Rails autoloading fails when ::Collection is undefined

[marrus-sh]

The change made in 53b0060 doesn’t actually work in environments with autoloading when there is no ::Collection; the .safe_constantize creates a recursive loop which just tries to load the same file again.

We got around this by just doing Object.const_set(:Collection, Hyrax.config.collection_class) in an initializer, but this isn’t ideal.

[marrus-sh]

If you need :Collection to be nil in an initializer (for example, so that Valkyrie.config.resource_class_resolver can define it), the following worked for me :—

Object.const_set(:Collection, true)
require_dependency "#{Gem.loaded_specs["hyrax"].full_gem_path}/app/models/collection"
Object.send(:remove_const, :Collection)

[marrus-sh]

Digging a little more into this… this only happens when ::Collection is referenced in an initializer (outside of e·g a to_prepare). If Rails manages to complete initialization, then the implemented solution seems to work.

Not sure why this is exactly.