Fix “::Collection” definition with autoloading #6758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
reviewed
Mar 27, 2024
In autoloaded environments which reference `::Collection` in an initializer, `safe_constantize` will create a recursive autoloading loop. We can hook into `ActiveSupport::Dependencies` to check whether this is going to happen, and pre·emptively return `false` in that case (so that `::Collection` is defined properly), without changing behaviour where `::Collection` is getting `safe_constantize`d from somewhere else.
marrus-sh
force-pushed
the
hyrax_fix_collection
branch
from
3cbdaa9
to
eebfaa4
Compare
dlpierce
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In autoloaded environments which reference
::Collectionin an initializer,safe_constantizewill create a recursive autoloading loop. We can hook intoActiveSupport::Dependenciesto check whether this is going to happen, and pre·emptively returnfalsein that case (so that::Collectionis defined properly), without changing behaviour where::Collectionis gettingsafe_constantized from somewhere else.Fixes
Fixes #6736