Gemfile - update engine cart stanza for v1.1.0

[dazza-codes]

Related to cbeer/engine_cart#79 (does not fix it in engine_cart)

@projecthydra-labs/hyrax-code-reviewers

@mjgiarlo - I just discovered that this could undo a prior hack on the engine-cart stanza:

• 8071e33
• Is there another way to achieve that without hacking the engine-cart stanza?
  • attempted to do so in fefd490
• review commentary resolved to ignore overriding this gem version for rails 4.2 because hyrax needs rails 5.x now anyway, so the commit ^^ was removed.

[dazza-codes]

@cbeer - add rubocop checks on engine_cart so it's stanza passes rubocop checks.

Gemfile:41:5: C: Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem coffee-rails should appear before sass-rails.

    gem 'coffee-rails', '~> 4.1.0'

    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This motived this issue on engine_cart at cbeer/engine_cart#80

[jcoyne]

This seems like it conflicts with line 44. Can you say more about why we need both?

[dazza-codes]

The line-44 code is maintained by engine-cart, it should not be modified by anything but engine cart and we should assume that engine-cart will not respect any changes in the block it maintains. To override anything in that block, it must be declared separately. So, in this PR, to preserve the intention of a prior commit, this block was added in the last commit.

[dazza-codes]

A separate issue is whether this override is actually needed at all any more, so I did not intend to address that in this PR.

[jcoyne]

@darrenleeweber but we don't support rails 4.2, and this block appears to specifically be for Rails 4.2.

[cbeer]

The line-44 code is maintained by engine-cart, it should not be modified by anything but engine cart

I wouldn't go that far -- instead, I'd say: by modifying it, the onus is on the project maintainers to ensure it is maintained the way they expect.

I thought having duplicate gem declarations (particularly conflicting ones) makes bundler unhappy?

[dazza-codes]

Good question - I have not tested what happens when the rails version hits this code. If hyrax is no longer compatible with rails 4.x, then I should just remove the last commit and leave that stanza as engine-cart creates it (i.e. discard the override entirely).

[cbeer]

👍

[dazza-codes]

Removed the last commit to override anything on rails 4.2

[jcoyne]

@darrenleeweber but we don't support rails 4.2, and this block appears to specifically be for Rails 4.2.