Fixes #3178 - Add Select All functionality to Manage Expired Embargo … #3246
Conversation
|
👏 This is a great contribution! |
| @@ -1,3 +1,3 @@ | |||
| <div data-behavior="batch-add-button"> | |||
| <%= check_box_tag "batch_document_ids[]", document.id, true, class:"batch_document_selector", id: "batch_document_#{document.id}" %> | |||
| </div> | |||
| <%= check_box_tag "batch_document_ids[]", document.id, false, class:"batch_document_selector", id: "batch_document_#{document.id}" %> | |||
There was a problem hiding this comment.
Can you comment about how this change is related? I don't follow at a glance (I guess it has something to do with fallout from the javascript changes?) and want to make sure someone picking up the code later could understand.
There was a problem hiding this comment.
@no-reply Thanks for reviewing! I tested that without explicitly defining, the checked attribute for check_box_tag( with class:"batch_document_selector") default to true. The test was done in the master branch which is before this javascript change.
So I think it has to explicitly define as false to make it unchecked when page loaded. Is this the behavior that we wanted?
| @@ -18,11 +18,11 @@ | |||
| <% else %> | |||
|
|
|||
| <%= form_tag embargoes_path, method: :patch do %> | |||
| <%= submit_tag t('.deactivate_selected'), class: 'btn btn-primary' %> | |||
| <%= submit_tag t('.deactivate_selected'), class: 'btn btn-primary' %> | |||
There was a problem hiding this comment.
If you have a chance, let's get rid of the trailing whitespace on this line.
…table.
Fixes #3178 ; refs #3178
Here is the screenshots for after changes:
@samvera/hyrax-code-reviewers