Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap dashboard sidebar in <nav> element for better accessibility #3251

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Wrap dashboard sidebar in <nav> element for better accessibility #3251

merged 1 commit into from
Sep 12, 2018

Conversation

adamjarling
Copy link
Member

Fixes #3085

Wraps the Dashboard sidebar in <nav> element for improved accessibility.

@samvera/hyrax-code-reviewers

@adamjarling adamjarling self-assigned this Sep 10, 2018
no-reply
no-reply approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 This looks great.

@no-reply no-reply merged commit 465571f into master Sep 12, 2018
@no-reply no-reply deleted the 3085-dashboard-side-nav-wrap-in-nav branch September 12, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no-reply no-reply no-reply approved these changes

Assignees

@adamjarling adamjarling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamjarling @no-reply @mjgiarlo