Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default terms text in template to ordered list #3258

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Sep 11, 2018

Fixes #2983

  • Uses ordered list tags in markup rather than <p> in the generator template for the Terms of Use page.

Note: This changes the markup for the terms in the generator template, which is populated in the database (one time only) on first terms access. After that, the text is editable by users. So, for testing, you may not see changes unless db is cleared.

@samvera/hyrax-code-reviewers

@kdid kdid changed the title Changes default terms text in template to unordered list Changes default terms text in template to ordered list Sep 11, 2018
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@no-reply no-reply merged commit 8b0d3ba into master Sep 11, 2018
@no-reply no-reply deleted the 2983-terms-list branch September 11, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants