Configures dashboard graphs for better accessibility #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
requested changes
Sep 13, 2018
| Hyrax.statistics.repositoryGrowth = <%== repository_growth %> | ||
| //]]> | ||
| </script></div> | ||
| <table class="table table-striped sr-only text-left"> |
There was a problem hiding this comment.
This looks really good. The only suggestion I'd have to finish it off is aria labeling each table. For example:
<table aria-label="<%= t('.repository_growth.subtitle') %>" class="table table-striped sr-only text-left">
However that translation title sneaks in there...
There was a problem hiding this comment.
kdid
force-pushed
the
3040-dashboard-graphs
branch
from
3085fe7
to
26a53b9
Compare
adamjarling
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3040
@samvera/hyrax-code-reviewers