Wrap long file names in fileset and work show page #3332
Conversation
| @@ -18,7 +18,12 @@ header > h1 .label { | |||
| padding: $panel-body-padding; | |||
| } | |||
|
|
|||
| .relationships, | |||
| .attribute-filename, | |||
|
This looks great! Do you have thoughts about how to respond to the issue flagged by Hound? |
|
@no-reply - I'm having problem running bundle install for this branch after rebase with master branch and run the command rm -rf .internal_test_app Gemfile.lock . I'm working on it and will try to update css to avoid id selector. I'll keep you posted. Thanks for reviewing. |
VivianChu
changed the title
| td:first-child { | ||
| word-break: break-all; | ||
| } | ||
|
|
||
| .attributes { |
There was a problem hiding this comment.
Did you intend to remove .relationships from this selector?
There was a problem hiding this comment.
@jcoyne - It was a mistake. I added it back.
| .relationships, | ||
| .attribute-filename, | ||
| header h1, | ||
| td:first-child { |
There was a problem hiding this comment.
I think this is too generic of a selector for this. Can we make this a new class like .ensure-wrapped.
Slightly off topic, but I like how github handles situations like this:
There was a problem hiding this comment.
@jcoyne - The pages have been updated to use the new class .ensure-wrapped. Thanks for suggestion.
VivianChu
changed the title
Fixes #1275
Wrap long file names without spaces fit the layout.
Here's the screen shot of before and after the change
Before
After
@samvera/hyrax-code-reviewers