Fix Universal Viewer embed code #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
previously approved these changes
Oct 21, 2018
ghost
force-pushed
the
data_uri_uv
branch
2 times, most recently
from
5ef1356
to
40f8576
Compare
|
@jcoyne good spot, there is a separate PR for the NL translation, which I've backed out of here. |
cjcolvar
previously requested changes
Oct 22, 2018
There was a problem hiding this comment.
👍 Looks good, but there is a failing test that is testing exact equality that needs to get updated here: https://github.com/samvera/hyrax/blob/master/spec/features/work_show_spec.rb#L46
It would probably be good to update the comment above that line as well.
ghost
force-pushed
the
data_uri_uv
branch
3 times, most recently
from
8ca1ccf
to
24308ae
Compare
ghost
mentioned this pull request
|
The travis builds got all in a tangle when there were problems the other day, and now I can't seem to get them to run. Circle CI passed, is that enough?! |
ghost
changed the title
ghost
force-pushed
the
data_uri_uv
branch
2 times, most recently
from
8f1d236
to
9d4fe69
Compare
and respond with json to html get request to the manifest url
ghost
changed the title
Merged
|
I restarted the failed PR builds and now they don't have any test failures but are still exiting with an error. I'm going to go ahead and approve and merge this PR. |
cjcolvar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UV data-uri needs full URI otherwise the embed code won't work on other sites
Also, external sites will make a standard get request to the manifest, so we need to return the json manifest for both a json and html request