Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add form group wrappers to fieldsets on Edit work page #3359

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add form group wrappers to fieldsets on Edit work page #3359

merged 1 commit into from
Oct 31, 2018

Conversation

adamjarling
Copy link
Member

Fixes #3355

After

edit-work-form-groups-fix

Before

edit-works-page-spacing

@samvera/hyrax-code-reviewers

@adamjarling adamjarling self-assigned this Oct 30, 2018
afred
afred approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred
Copy link
Contributor

afred commented Oct 31, 2018

Merging this in spite of false-negative Circle Ci build failure.

@afred afred merged commit 6106a15 into master Oct 31, 2018
@afred afred deleted the 3355-edit-page-form-spacing branch October 31, 2018 16:48
@afred afred removed the in progress label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@adamjarling adamjarling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix form group spacing on Work/Collection edit pages
3 participants
@adamjarling @afred @mjgiarlo