Extra documentation for the ordered members change #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
ordered_members_doco
branch
2 times, most recently
from
2789436
to
45636e5
Compare
…a1107296a4def908b63eff1a97
ghost
force-pushed
the
ordered_members_doco
branch
from
45636e5
to
8041d02
Compare
jcoyne
approved these changes
Nov 5, 2018
|
The failing travis and circleci builds actually had all test passing. I'm going to go ahead and merge this and create a ticket for the false failing builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #fdaa8bc7bf45cfa1107296a4def908b63eff1a97