Remove conditional from user partial in favor of User#display_name
#3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`User#name` already handles this logic in a cleanly overridable way. It's also a bit nicer since it avoids repeated access and comparison on `#name` and `#user_key`. The goal is: display a nice displayable name when its available; display the `#user_key` as a fall back.
jcoyne
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User#namealready handles this logic in a cleanly overridable way. It's also abit nicer since it avoids repeated access and comparison on
#nameand#user_key.The goal is: display a nice displayable name when its available; display the
#user_keyas a fall back.This should behave as a straight refactor except when
#display_nameis customized. The assumption is that in this case, using#display_nameis desirable.@samvera/hyrax-code-reviewers