Require hyrax/search_state #3472
Conversation
When attempting to set the admin_set_create_service for the AdminSetsController in the hyrax initializer, you get an uninitialized constant error for Hyrax::SearchState. It is required in an initializer within the Hyrax engine but for some reason hasn't been loaded by that point in the hyrax initializer. This commit makes the dependency explicit by requiring the load of search state here.
|
FWIW The two failed travis builds had all of their rspec tests pass. |
|
This seems okay to me, but I'm not sure I'm understanding why the relevant requires need to be in an tantalizer at all. I'm going to try simply moving them out to the main body of the |
This loads dependencies from `lib/hyrax` and dry-rb explictly from Hyrax::Engine, instead of waiting until the initializer. This is an alternate implementation to the one in #3472
|
Do you have thoughts about https://github.com/samvera/hyrax/tree/require-wo-initializer ? |
|
That approach looks good to me. The only reason I can think of to load those later in an initializer is to help speed up the load time or because of some load order issue but those both seem unlikely and if they work outside of the initializer then I'm 👍. |
|
@no-reply Do you have time to rebase that branch and open a PR or would you like me to do that? |
|
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
This loads dependencies from `lib/hyrax` and dry-rb explictly from Hyrax::Engine, instead of waiting until the initializer. This is an alternate implementation to the one in #3472
This loads dependencies from `lib/hyrax` and dry-rb explictly from Hyrax::Engine, instead of waiting until the initializer. This is an alternate implementation to the one in #3472
|
Closed by #3686. |
When attempting to set the admin_set_create_service for the AdminSetsController in the hyrax initializer, you get an uninitialized constant error for Hyrax::SearchState. It is required in an initializer within the Hyrax engine but for some reason that hasn't been loaded by this point in the hyrax initializer. This commit makes the dependency explicit by requiring the load of search state here when Hyrax::Controller is used.
@samvera/hyrax-code-reviewers