Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change predicate used by keyword #3748

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Change predicate used by keyword #3748

merged 1 commit into from
Apr 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2019

Fixes #1505

  • Change the predicate in BasicMetadata
  • Add a migration service for changing predicates and rake task for the current change

The migration service updates the graph, moving data from the previous predicate to the new one, eg.

Hyrax::Works::MigrationService.migrate_predicate(
  ::RDF::Vocab::DC11.relation,
  ::RDF::Vocab::SCHEMA.keywords
)

For keywords, this changewill require running the following rake task and needs to be added to the release notes for this version:

rake hyrax:migrate:migrate_keyword_predicate

Note Rubocop complains about the use of @work in the test, hence the disable / enable statements. Using let the test fails - the predicates don't get updates. I am not sure why.

@ghost ghost force-pushed the 1505_keywords branch 4 times, most recently from 6e9f575 to 2c66d18 Compare April 16, 2019 17:49
@ghost ghost changed the title WIP Change predicate used by keyword Change predicate used by keyword Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to change mapping of required metadata property:keyword
1 participant