Use Arel.sql to wrap a known safe SQL string in PermissionsService
#3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To protect against injection attacks, `#pluck` has deprecated raw SQL strings in Rails 5.2. We could use `pluck(:source_id).uniq` here. This would be less efficient in some cases. I didn't have the time to look into whether those cases are likely to arise, so we simply mark the SQL string as safe by wrapping it with `Arel.sql()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To protect against injection attacks,
#pluckhas deprecated raw SQL strings inRails 5.2.
We could use
pluck(:source_id).uniqhere. This would be less efficient insome cases. I didn't have the time to look into whether those cases are likely
to arise, so we simply mark the SQL string as safe by wrapping it with
Arel.sql().Connected to #3030
@samvera/hyrax-code-reviewers