Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not disrupt item list when changing to masonry view #3913

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Aug 15, 2019

Fixes #3626

Prior to this change, if a collection contained some works and you were looking at the list of works on the collection home page, and switched to the masonry view, the sort button would be obscured, and the other view buttons would no longer work. Lowering the top margin a bit, corrects these problems.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Create a user collection or use an existing one.
  • Add a few works to the collection.
  • Go to the collection home page and make sure you are able to sort and change view configurations. Here is an image of what you are looking for in the collection home page.

Screen Shot 2019-08-15 at 2 06 31 PM

@samvera/hyrax-code-reviewers

@dlpierce dlpierce merged commit 3e26dc7 into master Aug 15, 2019
@dlpierce dlpierce deleted the issue-3626 branch August 15, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collection "views" don't work after choosing (masonry, list, etc)
2 participants