Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display full breadcrumb even when accessing the work/file/stat directly. #3914

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Aug 15, 2019

Fixes #3385

When going to a work, fileset or analytics page directly using the url, the full breadcrumb should display. Presently, the breadcrumb only displays when user arrives at these pages within the application.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Go to a work page, cp/pt the url onto a different tab on your browser. Confirm that the breadcrumb is complete in both browser tabs.
  • Do the same thing for the file_set page
  • Do the same thing for the analytics page.

@samvera/hyrax-code-reviewers

@blancoj blancoj force-pushed the issue-3385 branch 3 times, most recently from 57ea0d1 to 9a935c0 Compare August 16, 2019 15:49
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@no-reply no-reply merged commit 5584e5f into master Sep 4, 2019
@no-reply no-reply deleted the issue-3385 branch September 4, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

direct links to works, filesets, and analytics pages have no breadcrumbs
3 participants