[wings] Remove method missing #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivianChu
force-pushed
the
wings-pcdm-method-missing
branch
from
1509631
to
4467a26
Compare
|
@no-reply - 👍 LGTM . I rebased it with the master branch, tried to rerun the workflow twice and the tests still failed. I'll approve it when the tests pass. Could you take a look at the build? Thanks |
|
@VivianChu sorry, we're expecting this one to fail right now. @lsitu is looking into it |
There's no reason to pass through these methods, we'd prefer they fail. The `original_file` case is used internally, but sholud also be removed. Fixes #3928.
lsitu
force-pushed
the
wings-pcdm-method-missing
branch
from
4467a26
to
8a6cfa2
Compare
|
@no-reply @VivianChu All those failed tests that are relying on the removed method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to pass through these methods, we'd prefer they fail. The
original_filecase is used internally, but should also be removed.@samvera/hyrax-code-reviewers