add file_converter_service which converts the metadata between AF:File and FileMetadata resource #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
reviewed
Sep 18, 2019
elrayle
force-pushed
the
wings/file_metadata_conversion
branch
3 times, most recently
from
9d81988
to
44b9eeb
Compare
no-reply
reviewed
Sep 19, 2019
| end | ||
|
|
||
| def content(metadata_resource) | ||
| return nil if metadata_resource.content.nil? || metadata_resource.content.size.zero? |
There was a problem hiding this comment.
are we expecting metadata_resource.content to be nil or an Array? i'm wondering about the impact of size.zero? vs empty?. size is normally going to 0 or 1 i'd guess?
will return nil if metadata_resource.content.blank? work here?
There was a problem hiding this comment.
This is used to set the content in the AF:File. When there is no content (i.e. nil or []), then the content in the AF:File will be nil. If there is an empty string (i.e. ['']), then the content in the AF:File should be an empty string.
I confirmed that blank? works for all 3 of these conditions.
no-reply
previously approved these changes
Sep 19, 2019
…e and FileMetadata resource
elrayle
force-pushed
the
wings/file_metadata_conversion
branch
from
44b9eeb
to
e7dc33a
Compare
no-reply
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides conversions between AF:Files and FileMetadata resources.