Provide a Valkyrie changeset factory #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
hyrax-changesets
branch
2 times, most recently
from
7468716
to
5cb6f97
Compare
added 2 commits
October 3, 2019 13:16
For any given Valkyrie model, we want a factory for an appropriate `ChangeSet`, with attribute accessors and a `#sync` method. We provide this with a `Hyrax::ChangeSet.for(my_resource)` factory. This builds the changeset class on the fly, applying the fields from the resource schema. Then a new instance of the class is initialized to handle the `ChangeSet` for the specific object. As future work, we could consider caching the changeset classes. For now, it seems best to watch and wait--avoiding premature optimization.
Hyrax now has a change set class builder and factory. Use these to construct the change set instance for `AccessControl` objects in `AccessControlList`.
VivianChu
force-pushed
the
hyrax-changesets
branch
from
5cb6f97
to
06c130f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any given Valkyrie model, we want a factory for an appropriate
ChangeSet,with attribute accessors and a
#syncmethod.We provide this with a
Hyrax::ChangeSet.for(my_resource)factory. This buildsthe changeset class on the fly, applying the fields from the resource
schema. Then a new instance of the class is initialized to handle the
ChangeSetfor the specific object.
As future work, we could consider caching the changeset classes. For now, it
seems best to watch and wait--avoiding premature optimization.
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers