Use a custom Indexer for AdminSets #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
use-indexer-class-for-admin-sets
branch
from
2c951d4
to
9236840
Compare
cjcolvar
reviewed
Sep 27, 2019
no-reply
force-pushed
the
use-indexer-class-for-admin-sets
branch
from
9236840
to
6bf3ff7
Compare
added 2 commits
October 14, 2019 10:54
Indexing for admin sets is under-tested. Adding a test for keys helps ensure the behavior stays fixed under upcoming changes.
Avoid deprecated `index.as` syntax for `AdminSet` data. Admin Sets should be able to index using the AdminSetIndexer, rather than the old-style `index.as` syntax.
no-reply
force-pushed
the
use-indexer-class-for-admin-sets
branch
from
6bf3ff7
to
1cfabee
Compare
cjcolvar
reviewed
Oct 17, 2019
Co-Authored-By: cjcolvar <cjcolvar@indiana.edu>
|
@no-reply Maybe this needs a rebase to fix the valkyrie tests? Or invalidating the cache? |
|
@cjcolvar seems like the failure is an unrelated random error:
I've seen this one before, and it looks like a test order issue to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid deprecated
index.assyntax forAdminSetdata.Admin Sets should be able to index using the AdminSetIndexer, rather than the
old-style
index.assyntax.@samvera/hyrax-code-reviewers