Make the valkyrie index adapter configurable #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
valkyrie-indexer-config
branch
from
dd4768a
to
e76c27c
Compare
Add configuration for the indexing adapter to make access consistent with other valkyrie adapters. The one-true-way to access the indexing adapter is now `Hyrax.indexing_adapter`. We'll likely only really support the Solr indexing adapter (or things that very closely conform to its behavior) for the forseeable future.
no-reply
force-pushed
the
valkyrie-indexer-config
branch
from
e76c27c
to
6b47ade
Compare
|
@no-reply - LGTM 👍 However coverage/coveralls failed because coverage decreased 6.9%. Do you need to add test to make that increase the coverage? |
|
@VivianChu coveralls routinely reports coverage varying by this much. it's unrelated to this PR. we made coveralls a non-required check for this reason, and have plans to remove it entirely. |
VivianChu
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for the indexing adapter to make access consistent with other
valkyrie adapters. The one-true-way to access the indexing adapter is now
Hyrax.indexing_adapter.We'll likely only really support the Solr indexing adapter (or things that very
closely conform to its behavior) for the forseeable future.
@samvera/hyrax-code-reviewers