Remove call to dead ActiveFedora code #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conditional was needed to support ActiveFedora 11. We have since dropped support, so the check is no longer needed.
|
@no-reply what is the procedure for a drop in coverage? The build says its broken. |
|
@jeremyf coveralls has been chronically unreliable on this project. There's a known TODO item to remove it. It is already turned off as a required build on Github's settings, which unblocks merge, but doesn't prevent the ❌ from showing. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditional was needed to support ActiveFedora 11. We have since dropped
support, so the check is no longer needed.
@samvera/hyrax-code-reviewers