Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update work generator usage documentation #4187

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

no-reply
Copy link
Contributor

This documentation was far out of date, and barely listed half of what the
generator actually does in practice.

@samvera/hyrax-code-reviewers

This documentation was *far* out of date, and barely listed half of what the
generator actually does in practice.

I reran it locally and copied the output.
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this list of files sorted by the order in which they are created or some relative importance? Does it make sense to alphabetically sort it? It is mostly alphabetically sorted but not all the way.

@no-reply
Copy link
Contributor Author

no-reply commented Jan 16, 2020

it's the order they are output by the generator, except with the model itself (and its spec) moved to the top of the groups listing app/* and spec/*, i kept the model and model_spec at the top in keeping with prior behavior

@no-reply no-reply merged commit 97f1d23 into master Jan 17, 2020
@no-reply no-reply deleted the update-generator-usage branch January 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants