Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Valkyrie indexing for Collections #4223

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Implement Valkyrie indexing for Collections #4223

merged 5 commits into from
Jan 29, 2020

Conversation

no-reply
Copy link
Contributor

Add an indexer for valkyrie-based Hyrax::PcdmCollection and index "generic type" and "thumbnail".

@samvera/hyrax-code-reviewers

Tom Johnson added 2 commits January 26, 2020 20:21
Refactor CollectionMemberSearchBuilder to better use FilterByType
48e7525 
`Hyrax::FilterByType` already includes infrastructure for filtering by
collection and work types. Rather than implement a new switch, use its existing
`only_works?` and `only_collections?` to filter by "generic type".
Test CollectionMemberSearchBuilder with a Valkyrie collection
f11054b 
Adds tests for collection member search using Valkyrie `Hyrax::PcdmCollection`.
@straleyb
Copy link
Contributor

I left some comments here if anyone takes a peek at this. Im also going to add an in progress tag, so people who look at it know its not ready yet. Im not sure this is deviating, but ill add [WIP] on this too since there is still some stuff going on with it.

@straleyb straleyb changed the title Implement Valkyrie indexing for Collections [WIP] Implement Valkyrie indexing for Collections Jan 27, 2020
@no-reply
Copy link
Contributor Author

@straleyb normally we use [WIP] to indicate PR's that might not be ready for review. is it your opinion that that applies here?

@no-reply
Copy link
Contributor Author

ah yeah, it looks like i'm still stuck on some of the shared examples. I'll poke at this for some more, and let's leave the [WIP] in place.

thanks!

@straleyb straleyb changed the title [WIP] Implement Valkyrie indexing for Collections Implement Valkyrie indexing for Collections Jan 28, 2020
@straleyb straleyb changed the title Implement Valkyrie indexing for Collections [WIP] Implement Valkyrie indexing for Collections Jan 28, 2020
@straleyb
Copy link
Contributor

@no-reply Thanks for filling me in on some of these conventions. I didnt know that it 'things and stuff happen' was a valid convention for a pending test. Threw me off seeing that and made me think some block not given error would pop up or something.

Once this has been updated, whether I take a stab at getting those tests to pass or you, this looks good to get in.

@no-reply no-reply force-pushed the valkyrie_collections_controller branch from 9176100 to e588855 Compare January 28, 2020 23:03
@no-reply no-reply changed the title [WIP] Implement Valkyrie indexing for Collections Implement Valkyrie indexing for Collections Jan 28, 2020
@no-reply
Copy link
Contributor Author

@straleyb i think this should pass now

@straleyb
Copy link
Contributor

Looks pretty index-y to me! :merge:

@straleyb straleyb merged commit 23e3a25 into master Jan 29, 2020
@straleyb straleyb deleted the valkyrie_collections_controller branch January 29, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straleyb straleyb straleyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no-reply @straleyb