Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permission level configuration defaults use I18n locale. #4287

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

cjcolvar
Copy link
Member

Any overrides of these defaults in initializers would remove the ability to support multiple languages as pointed out by @j-dornbusch in #4285. Thus I'm not exactly sure of the value of these configuration methods if the values have been put in the locale, but I left them as-is to be backwards compatible.

Fixes #4285

@samvera/hyrax-code-reviewers

@cjcolvar cjcolvar changed the title Make configuration defaults use I18n locale. Make permission level configuration defaults use I18n locale. Apr 16, 2020
@cjcolvar cjcolvar force-pushed the permission_level_i18n branch 2 times, most recently from c36cd2d to 0b795fa Compare April 17, 2020 01:00
@ghost
Copy link

ghost commented Apr 20, 2020

Here is a proposal for a French translation.

    permission_levels:
      edit: "Modification" 
      read: "Consultation" 
      owner:
        edit: "Modification" 
      options:
        edit: "Modifier" 
        none: "Choisir un niveau de droits" 
        read: "Consulter/télécharger" 

@jmfrenzel may have the german wording.

@no-reply
Copy link
Contributor

rebased and pushed, without the regen, which has been patched in #4289

Any overrides of these defaults in initializers would remove the ability
to support multiple languages as pointed out by @j-dornbusch in #4285.
@no-reply no-reply merged commit 84c7973 into master Apr 24, 2020
@no-reply no-reply deleted the permission_level_i18n branch April 24, 2020 00:36
@cjcolvar
Copy link
Member Author

Here is a proposal for a French translation.

    permission_levels:
      edit: "Modification" 
      read: "Consultation" 
      owner:
        edit: "Modification" 
      options:
        edit: "Modifier" 
        none: "Choisir un niveau de droits" 
        read: "Consulter/télécharger" 

@jmfrenzel may have the german wording.

@j-dornbusch This PR was merged before I addd your French translation. Do you mind making a Pull Request for your translation or maybe wait to fix all of the Google-translated strings at one time after the i18n script has been run?

@no-reply
Copy link
Contributor

no-reply commented May 6, 2020

i'm realizing that these will still be 'hard coded', just to whatever the locale is when the app starts up. i think we need to rip out these configuration methods altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission options cannot be translated
2 participants