implement a solr health check #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
previously approved these changes
Apr 25, 2020
no-reply
force-pushed
the
solr-health-check
branch
2 times, most recently
from
bf0baf0
to
e3e2553
Compare
cjcolvar
reviewed
Apr 27, 2020
this check fails if it can't reach Solr, and succeeds otherwise.
no-reply
force-pushed
the
solr-health-check
branch
3 times, most recently
from
75220ef
to
6e09a36
Compare
avoid hard overwrites of Hyrax configuration in the SolrService specs. the contract here guarantees that the configuration given in the initalizer will be used. take advantage of that to better isolate and deduplicate the tests. if we need to check the default setting (i don't think we do), we can always check that the setting is correct after a generic `described_class.new` separately from these more complex behavioral tests.
no-reply
force-pushed
the
solr-health-check
branch
5 times, most recently
from
eb31974
to
1c0b6de
Compare
add a ping method to the `Hyrax::SolrService`, allowing for cheap Solr connection checks. this method returns `true` when the solr service returns an `"OK"` status, and may do anything else otherwise.
no-reply
force-pushed
the
solr-health-check
branch
from
1c0b6de
to
32e3e94
Compare
cjcolvar
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this check fails if it can't reach Solr, and succeeds otherwise.
@samvera/hyrax-code-reviewers