use helpers to i18nize configured permission levels/options

[no-reply]

these configured options (why do they need to be configurable? how would one
configure them successfully?) need to be i18nized, but the current fix only
caches the i18n strings at app startup (or maybe when the configurations are
first hit?).

to translate on-the-fly we need to hit the i18n key while the user is in the
desired locale.

this is a stop-gap fix. probably we want to make the configuration options just
straight arrays, or remove them completely. discussion on longer term approachs
is scheduled in https://wiki.lyrasis.org/display/samvera/Samvera+Tech+Call+2020-06-05.

related to #4297.

@samvera/hyrax-code-reviewers

[cjcolvar]

I believe this isn't backwards compatible if anyone has been customizing these by doing something like Hyrax.config.permission_levels = {} in an initializer.
I don't know what the use case would be for customizing the values and I think replacing customizable keys with i18n locale strings is the best long-term approach. So deprecate in 2.x and make the switch in 3.0?

[no-reply]

I believe this isn't backwards compatible if anyone has been customizing these by doing something like Hyrax.config.permission_levels = {} in an initializer.

why not? the configs are still used by the helpers.

---

to clarify, i think in the current implementation, Hyrax.config.permission_levels = {} will work fine; this would lead the associated helper to also return an empty hash.

Hyrax.config.permission_levels = { 'Hamburger' => 'edit', 'Lettuce' => 'read' } won't work, in the sense that "Hamburger" and "Lettuce" would be ignored completely and replaced by the i18nized values. i think this latter part is a feature, rather than a bug, and could just go in the 3.0.0 release notes.

[bkeese]

👍

made these changes