Addressing case where children are added again #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelakes
previously approved these changes
May 7, 2020
Prior to this commit, there was no guard in place to prevent adding children again. The logic would check "is something marked for delete" if not, then add it. That needed to change, because when a user would submit a form changing keywords, then we would re-add all of the already added members. Closes #4301 (which relates to #4193 and #4278) Related to #4302
cjcolvar
reviewed
May 7, 2020
jeremyf
force-pushed
the
gh-4301
branch
2 times, most recently
from
0d856fc
to
f8fee06
Compare
Prior to this commit, there were no specs handling the two axis of variance: Axis 1: A work is or is not already an existing member of the parent work. Axis 1: The passed attributes hash has marked an object for destroy, or for addition. This spec is hear to capture that relationshp.
no-reply
approved these changes
May 7, 2020
no-reply
reviewed
May 7, 2020
| @@ -1,3 +1,4 @@ | |||
| require 'csv' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was no guard in place to prevent adding
children again.
The logic would check "is something marked for delete" if not, then
add it. That needed to change, because when a user would submit a
form changing keywords, then we would re-add all of the already added
members.
Closes #4301 (which relates to #4193 and #4278)
Related to #4302
@samvera/hyrax-code-reviewers