Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand the EmbargoManager interface to handle releasing embargos #4305

Merged
merged 3 commits into from
May 12, 2020
Merged

expand the EmbargoManager interface to handle releasing embargos #4305

merged 3 commits into from
May 12, 2020

Commits on May 7, 2020

  1. expand the EmbargoManager interface to handle releasing embargos 

    for Valkyrie models, we provide `Hyrax::EmbargoManager` to make the embargo
lifecycle easy to work with. to date, this has only supported applying
embargoes. this adds the ability to release an embargo after its period has expired.

a concept of 'enforcement' is added, represented by `#enforced?`. this addresses
the issue of embargoes which are not current (their period is past) but have not
yet been released.

the terminology used by the `EmbargoManager` is documented.

see also: samvera/hydra-head#511.
    tom johnson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8a784b3 View commit details
    Browse the repository at this point in the history

  2. document and test Hyrax::LeaseManager 

    `LeaseManager` is substantially similar to `EmbargoManager`, and got in without
tests, with the idea that a refactor might quickly take place. it didn't and at
this point it needs a test harness if that's ever going to happen.

in the meanwhile. there are features we want to add to cover the remainder of
the lifecycle.
    tom johnson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    a43faee View commit details
    Browse the repository at this point in the history

  3. expand the LeaseManager interface to handle releasing leases

    tom johnson committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4e868ba View commit details
    Browse the repository at this point in the history