pin reform to v2.2.x and under #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Reform v2.3.1 release broke `reform-rails` and `valkyrie`. trailblazer/reform#508 the plan on the `trailblazer` side appears to be to roll forward by releasing a new, compatible version of `reform-rails`. to fix the build in the meanwhile, pin `reform` to a working release. if `reform-rails` is released from a current release candidate, that should also patch this issue; see #4332. assuming that happens before Hyrax 3.0.0, we can bump both the `reform` and `reform-rails` depend on the latest versions directly.
escowles
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Reform v2.3.1 release broke
reform-railsandvalkyrie. trailblazer/reform#508the plan on the
trailblazerside appears to be to roll forward by releasing anew, compatible version of
reform-rails. to fix the build in the meanwhile,pin
reformto a working release.if
reform-railsis released from a current release candidate, that should alsopatch this issue; see #4332. assuming that
happens before Hyrax 3.0.0, we can bump both the
reformandreform-railsdepend on the latest versions directly.
@samvera/hyrax-code-reviewers