auto-generate tests for attributes in work resource generator #4348
Conversation
Confirms that the generated work resource responds to all generated metadata.
| return unless attributes.present? | ||
| inject_into_file filepath, after: /it_behaves_like 'a Hyrax::Work'\n/ do | ||
| "\n context 'includes schema defined metadata' do\n"\ | ||
| "#{attributes.collect { |arg| " it { is_expected.to respond_to(:#{arg.name}) }\n" }.join}" \ |
There was a problem hiding this comment.
i don't think this needs to be wrapped in string interpolation
| "#{attributes.collect { |arg| " it { is_expected.to respond_to(:#{arg.name}) }\n" }.join}" \ | |
| attributes.collect { |arg| " it { is_expected.to respond_to(:#{arg.name}) }\n" }.join |
has the same result?
There was a problem hiding this comment.
I tried creating it without and it didn't work. Since I'd made several tweaks getting this to work, I tried it again, and it still doesn't work. Perhaps with much fiddling around I could figure out either why it doesn't work or how to make it work. Not sure it is worth it. I did a quick test in irb following the same pattern of multi-line string with block in the middle and it also failed with a syntax error.
There was a problem hiding this comment.
Do you think it is possible to put this all inside the template and avoid the injection?
There was a problem hiding this comment.
the injection is conditional on attributes.present?, but maybe it should not be?
i.e. what if we put the outline, including the context block in the template, plus a # it { is_expected.to respond_to(:my_attribute}) line as guidance for app developers. then let the injection take place only for the custom attrs.
There was a problem hiding this comment.
in either case. i'm approving this. i think we should merge as-is and refine from there.
There was a problem hiding this comment.
@cjcolvar How would you put that in the template? The attributes are defined inline with the generator. You could put an example in the template, but I’m not sure that really buys us anything. I don’t know another way to add to a template other than using inject_into_file.
There was a problem hiding this comment.
I'm not sure but I'd assume that the arguments would be available for use within the template so you could generate it just like you are now but in ERB style.
|
looks good to me. i made a simplifying suggestion. |
|
I'm excited by a generator that can actually build a fully working work type! |
Confirms that the generated work resource responds to all generated metadata.
Related to PR #4347
@samvera/hyrax-code-reviewers