Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming method from whitelisted to registered #4357

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Jun 8, 2020

The words we use matter. They perpetuate stereotypes, enforcing the
idea that "black" is unacceptable and "white" is acceptable.

There continue to be references to white and black list. However,
those appear to come from upstream dependencies.

@samvera/hyrax-code-reviewers

The words we use matter.  They perpetuate stereotypes, enforcing the
idea that "black" is unacceptable and "white" is acceptable.

There continue to be references to white and black list. However,
those appear to come from upstream dependencies.
Copy link
Contributor

@bkeese bkeese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Jeremy

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
FWIW it looks like Rails was looking at using allowlist/denylist as replacements but for the changes proposed in this PR I think registered is a clearer term.

@jcoyne jcoyne merged commit 0fb9b48 into master Jun 8, 2020
@jcoyne jcoyne deleted the rename-white-list branch June 8, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants