support Valkyrie work creation with Hyrax transactions #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
tx-create-controller
branch
from
2b65be6
to
33ec06a
Compare
no-reply
force-pushed
the
tx-create-controller
branch
3 times, most recently
from
d4e9b75
to
e69699e
Compare
bump `Hyrax::Transactions` into the engine for use with Valkyrie resources. provide a `#transactions` method for controllers via `Hyrax::Controller`, to support easy reference to transactions (by name).
no-reply
force-pushed
the
tx-create-controller
branch
from
e69699e
to
b912535
Compare
added 2 commits
June 29, 2020 11:36
add Valkyrie work creation handling for `WorksControllerBehavior`. this uses `Hyrax::Transactions` to process the work.
stub `registered_curation_concern_types` to simplify setup for registered concerns on test controllers. this is lighter weight and less error prone than actually registering the concern, with the tradeoff of being more tightly coupled to the configuration implementation details.
no-reply
force-pushed
the
tx-create-controller
branch
from
21b8479
to
15d2bca
Compare
the test routes need to be targeted on the `main_app` helper, since we want to register them on the host app. the stubs here are maybe not the ideal solution, but they seem to do the trick.
no-reply
force-pushed
the
tx-create-controller
branch
from
2813624
to
58b06d2
Compare
jeremyf
reviewed
Jun 30, 2020
| # A mixin for Hyrax support methods. This is meant to be included in | ||
| # `ApplicationController`. | ||
| # | ||
| # @note private methods within this module are normally still "public API", |
There was a problem hiding this comment.
Excellent comment to clarify!
jeremyf
reviewed
Jun 30, 2020
| after(:context) do | ||
| config = Hyrax.config | ||
| types = config.registered_curation_concern_types - ["Hyrax::Test::SimpleWork"] | ||
| before do |
There was a problem hiding this comment.
Is this working now? I'd imagine extracting a general support module might be helpful.
There was a problem hiding this comment.
i think it's working! nothing else is yet using similar behavior, but i'm 👍 on extracting before we end up duplicating this elsewhere.
jeremyf
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Valkyrie work creation handling for
WorksControllerBehavior. this usesHyrax::Transactionsto process the work.to accomplish this, we first bump
Hyrax::Transactionsinto the engine for use with Valkyrie resources.@samvera/hyrax-code-reviewers