Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display thumbnail in public collection page. Fixes issue #3358 #4360

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

blancoj
Copy link
Contributor

@blancoj blancoj commented Jun 9, 2020

Fixes #3358

If an image has been selected to serve as the thumbnail for a collection, then the thumbnail should be visible in the descriptive metadata area of the public show page for the collection. Before this PR, the representative image was not showing up. I have placed the image right above the "Collection Details". It seemed to me that if the collection had a banner and a long title this is where it would look the best.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Create a public collection
  • Create a public work that includes an image file
  • Put the work in the collection
  • Edit the collection and select the work's image as the thumbnail for the collection
  • Navigate to the collection's public show page. Notice that the representative thumbnail is right above the Collection Details.

You can experiment by adding a banner to the collection and title and see how it looks. Attached is an image of how it rendered for me:
Screen Shot 2020-06-09 at 11 21 29 AM

@samvera/hyrax-code-reviewers

elrayle
elrayle previously approved these changes Jun 12, 2020
Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good

@elrayle elrayle merged commit 0e46e47 into master Jun 13, 2020
@elrayle elrayle deleted the issue-3358 branch June 13, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection show page does not show thumbnail
2 participants