pin EBUCore to avoid changed predicates used by Hyrax #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin to a version of the vocabulary gem that supports the old EBUCore. A data migration will be required for any prospective update involving ActiveFedora.
no-reply
changed the title
K8Sewell
approved these changes
Jun 11, 2020
jrgriffiniii
approved these changes
Jun 11, 2020
|
I will delay merging until the RSpec test suites complete, but this seems stable. |
|
https://app.circleci.com/pipelines/github/samvera/hyrax/3495/workflows/839511bc-b992-4ba7-9a1f-6bdc9939ae16/jobs/22643/steps seem to be flapping tests unrelated to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin to a version of the vocabulary gem that supports the old EBUCore. A data
migration will be required for any prospective update involving ActiveFedora.
@samvera/hyrax-code-reviewers