test & document DisplaysImage fallback behavior #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2020 16:21
when no `original_file_id` is available on an indexed file_set, we have a fallback approach, retrieving the data from datastore (via ActiveFedora for now) and resolving it via `VersioningService`.
this method has pretty specific, complicated behavior. documenting it will be a big help to future developers.
jeremyf
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when no
original_file_idis available on an indexed file_set, we have afallback approach, retrieving the data from datastore (via ActiveFedora for
now) and resolving it via
VersioningService.@samvera/hyrax-code-reviewers