pass base_url, not just hostname through to manifest generation
#4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
previously approved these changes
Dec 12, 2020
this change realigns with older Hyrax behavior that used the protocol from the current controller's request as part of the argument to the IIIF image URI generator.
no-reply
force-pushed
the
reinstate-manifest-protocol-inference
branch
from
ec79fb0
to
f89417b
Compare
no-reply
pushed a commit
that referenced
this pull request
Dec 12, 2020
|
This is likely a good change and moves you in the right direction. I would still recommend double checking the nginx or Apache headers or this may least to a forgery error (request.base_url does not match http origin or something like that). See https://serverok.in/nginx-rails-origin-header-didnt-match for the most concise of the thousand or so people running in to this ;-) |
orangewolf
approved these changes
Dec 13, 2020
jeremyf
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change realigns with older Hyrax behavior that used the protocol
from the current controller's request as part of the argument to the IIIF image
URI generator.
related to #4572.
@samvera/hyrax-code-reviewers