Switching blacklight http_method to :post #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because too many times on Samvera tech people raise a problem regarding a failed query to SOLR. Often, it's because they inadvertantly exceeded the character limit of a GET request.
no-reply
approved these changes
Jan 19, 2021
|
should we backport to 2.x? |
|
Pushing the backport now-ish. |
|
awesome! thank you! |
jeremyf
added a commit
to scientist-softserv/britishlibrary
that referenced
this pull request
Dec 15, 2022
Reviewing the logs I found:
```shell
ERROR -- : [c94e8538d4e27e31ce8995e3cf6af992] RSolr::Error::Http - 400 Bad Request
Error: {
"responseHeader":{
"zkConnected":true,
"status":400,
"QTime":0,
"params":{
"facet.field":["human_readable_type_sim",
"resource_type_label_ssim",
"creator_search_sim",
"keyword_sim",
"subject_sim",
```
The following line showed a string that was 2284 characters long and
ended in `f.member_of_collection_ids_ssim.facet.matches=%5E%24`; those
trailing characters decoded `^$` which could be a complete end of a
query (e.g. an empty string regexp match).
Related to:
- samvera/hyrax#4728
- #222
jeremyf
added a commit
to scientist-softserv/britishlibrary
that referenced
this pull request
Dec 21, 2022
Reviewing the logs I found:
```shell
ERROR -- : [c94e8538d4e27e31ce8995e3cf6af992] RSolr::Error::Http - 400 Bad Request
Error: {
"responseHeader":{
"zkConnected":true,
"status":400,
"QTime":0,
"params":{
"facet.field":["human_readable_type_sim",
"resource_type_label_ssim",
"creator_search_sim",
"keyword_sim",
"subject_sim",
```
The following line showed a string that was 2284 characters long and
ended in `f.member_of_collection_ids_ssim.facet.matches=%5E%24`; those
trailing characters decoded `^$` which could be a complete end of a
query (e.g. an empty string regexp match).
Related to:
- samvera/hyrax#4728
- #222
- #223
- @9253f1a0c3cee81941c779765eb6a360309ea77b
jeremyf
added a commit
to scientist-softserv/britishlibrary
that referenced
this pull request
Jan 11, 2023
Reviewing the logs I found:
```shell
ERROR -- : [c94e8538d4e27e31ce8995e3cf6af992] RSolr::Error::Http - 400 Bad Request
Error: {
"responseHeader":{
"zkConnected":true,
"status":400,
"QTime":0,
"params":{
"facet.field":["human_readable_type_sim",
"resource_type_label_ssim",
"creator_search_sim",
"keyword_sim",
"subject_sim",
```
The following line showed a string that was 2284 characters long and
ended in `f.member_of_collection_ids_ssim.facet.matches=%5E%24`; those
trailing characters decoded `^$` which could be a complete end of a
query (e.g. an empty string regexp match).
Related to:
- samvera/hyrax#4728
- #222
bkiahstroud
added a commit
to scientist-softserv/palni-palci
that referenced
this pull request
Aug 28, 2024
:post has a higher character limit than the default (:get) See: - samvera/hyrax#4728 - samvera/hyrax@e8edc51
bkiahstroud
added a commit
to scientist-softserv/palni-palci
that referenced
this pull request
Aug 29, 2024
:post has a higher character limit than the default (:get) See: - samvera/hyrax#4728 - samvera/hyrax@e8edc51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because too many times on Samvera tech people raise a problem regarding
a failed query to SOLR. Often, it's because they inadvertantly exceeded
the character limit of a GET request.
@samvera/hyrax-code-reviewers