make VersionPresenterList an Enumerable; extract creation to factory #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VersionPresenterList` is effectively an `Enumerable` (responds only to `#each`), extending it with `include Enumerable` makes it more versitile (perhaps we should consider a rename?). the current implementation relies on loading each member up-front and then sorting, but this might not be necessary for all backends. `Enumerable` also provides some guidance about how to do this kind of loading lazily. move the generation to a factory so the details of how to resolve an object to a list of versions are encapsulated.
no-reply
commented
May 24, 2021
jeremyf
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersionPresenterListis effectively anEnumerable(responds only to#each), extending it withinclude Enumerablemakes it moreversitile (perhaps we should consider a rename?). the current implementation
relies on loading each member up-front and then sorting, but this might not be
necessary for all backends.
Enumerablealso provides some guidance about howto do this kind of loading lazily.
move the generation to a factory so the details of how to resolve an object to a
list of versions are encapsulated.
@samvera/hyrax-code-reviewers