wings: versions for fcrepo #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support a versions interface for the valkyrie storage adapter. the interface developed here only applies to the access side---not to explicit version creation. since `fcrepo` creates the versions for us in the normal configuration, we can just rely on that for this adapter. further work is needed to validate that this interface is sufficient for Hyrax, and that some version of it can be implemented for other versioning storage layers (e.g. S3).
jeremyf
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support a versions interface for the valkyrie storage adapter. the interface
developed here only applies to the access side---not to explicit version
creation. since
fcrepocreates the versions for us in the normalconfiguration, we can just rely on that for this adapter.
further work is needed to validate that this interface is sufficient for Hyrax,
and that some version of it can be implemented for other versioning storage
layers (e.g. S3).
@samvera/hyrax-code-reviewers